fix(globalpatches): imeplement SharedDict:get_stale API #12233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It implements the `get_stale` API. 2. It completes the `set` API with support for the `flags` parameter. 3. It abstracts the `is_stale` function for reuse. 4. It does not delete expired data during referring operations. KAG-3398
chobits
force-pushed
the
cli_shdict_get_stale
branch
from
3556a5b to
897f411
Compare
ADD-SP
approved these changes
Dec 22, 2023
Water-Melon
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_staleAPI.setAPI with support for theflagsparameter.is_stalefunction for reuse.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-3398