feat(clustering/rpc): rpc batching on concentrator #14055
+130
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
| @@ -90,6 +93,67 @@ local function enqueue_notifications(notifications, notifications_queue) | |||
| end | |||
|
|
|||
|
|
|||
| function _M:process_one_response(payload) | |||
| assert(payload.jsonrpc == jsonrpc.VERSION) | |||
There was a problem hiding this comment.
We need to handle errors here. It could be an error of the opponent thus we should not fail in this case.
There was a problem hiding this comment.
Now this PR just refactored and moved the original code, kept the logic, we could change it later.
ADD-SP
reviewed
Dec 30, 2024
ADD-SP
reviewed
Dec 30, 2024
ADD-SP
approved these changes
Dec 30, 2024
chronolaw
force-pushed
the
feat/concentrator_rpc_batching
branch
from
78d8dec to
7af32ca
Compare
StarlightIbuki
approved these changes
Jan 14, 2025
chronolaw
force-pushed
the
feat/concentrator_rpc_batching
branch
from
7af32ca to
f70cc36
Compare
chobits
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5934
sister PR is #14040
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]