Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy-cache): let request no-cache arguement functionality follow… #14139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oowl
Copy link
Member

@oowl oowl commented Jan 13, 2025

… rfc

fix: #14120

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added plugins/proxy-cache cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jan 13, 2025
@xianghai2 xianghai2 requested a review from locao January 13, 2025 08:38
return signal_cache_req(ctx, conf, cache_key, "Bypass")
end
end

set_header(conf, "X-Cache-Key", cache_key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to add the cache key in the response?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/proxy-cache size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache-Control: no-cache from client request makes the response itself non-cacheable
3 participants