tests(clustering/rpc): add cases for sync.v2.get_delta #14151
Conversation
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
force-pushed
the
tests/mock_v2_get_delta
branch
from
d994317 to
b646fd4
Compare
|
|
||
| -- dp logs | ||
| helpers.pwait_until(function() | ||
| assert.logfile(name).has.line( |
There was a problem hiding this comment.
This kind of assertion already has timeout as the input parameter, so the pwait_until is not required.
There was a problem hiding this comment.
Not sure about it, if assertion fails wait_until may crush, so pwait_until is a better choice.
There was a problem hiding this comment.
I checked the code in spec/internal/wait.lua, pwait_until is different from wait_until, it can deal with assertion failings.
There was a problem hiding this comment.
Maybe I'm not clear enough, assert.logfile().has.line(pattern, boolean, timeout), we can pass the timeout into this assertion, so we don't need to warp it with wait_until or pwait_until.
There was a problem hiding this comment.
Got, let me try it.
There was a problem hiding this comment.
It works, but the tests take more time than pwait_until, so my opinion is keeping it.
spec/02-integration/18-hybrid_rpc/08-sync_v2_get_delta_spec.lua
Outdated
Show resolved
Hide resolved
spec/02-integration/18-hybrid_rpc/08-sync_v2_get_delta_spec.lua
Outdated
Show resolved
Hide resolved
Summary
KAG-6179
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]