feat(keys): add a new field x5t to the entity keys
#14154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db/migrations
core/clustering
core/db
schema-change-noteworthy
cherry-pick kong-ee
catbro666
force-pushed
the
fti-6399-keys-entity-adds-x5t
branch
2 times, most recently
from
1be97f2 to
b27d349
Compare
catbro666
force-pushed
the
fti-6399-keys-entity-adds-x5t
branch
from
b27d349 to
a330557
Compare
liverpool8056
requested changes
Jan 23, 2025
| if x5t_type ~= "string" then | ||
| return nil, "parameter `x5t` must be of type string" | ||
| end | ||
| if set_id_type ~= "string" and set_id_type ~= "nil" then |
There was a problem hiding this comment.
miswritten?
Suggested change
| if set_id_type ~= "string" and set_id_type ~= "nil" then | |
| if set_id_type ~= "string" or set_id_type ~= "nil" then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jwe-decrypt plugin wants to support searching key by x5t, so there's this PR.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-6399