Repository navigation
[backport -> release/3.9.x] fix(response-ratelimiting): fix missing usage headers for upstream - #15052
Open
ozsaygin wants to merge 3 commits into
Open
[backport -> release/3.9.x] fix(response-ratelimiting): fix missing usage headers for upstream#15052ozsaygin wants to merge 3 commits into
ozsaygin wants to merge 3 commits into
Conversation
…ong#13696) `response-ratelimiting` plugin should send usage headers to upstream server. But in Kong 3.8, there are no usage headers such as `X-RateLimit-Remaining-Videos: 10` for upstream requests. In this change, it coming back usage headers for upstream. KAG-5447 (cherry picked from commit 2582e76) Co-authored-by: Yukinari Toyota <yukinari.yt.toyota@jp.ricoh.com> Co-authored-by: Guilherme Salazar <gsz@acm.org> Co-authored-by: BrianChen <chenjingbo35@gmail.com>
(cherry picked from commit 2582e76) Co-authored-by: Yukinari Toyota <yukinari.yt.toyota@jp.ricoh.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #13696 to
release/3.9.x.Summary
Since 3.8,
response-ratelimitingsends theX-RateLimit-Remaining-<limit>usage headers to the client instead of the upstream, and ignoreshide_client_headers. #13696 fixed this on master and was labeledbackport release/3.9.x, but the automated backport never ran (no bot comment, noincomplete-backportlabel), so 3.9.3 and 3.9.4 still have the bug.The diff is identical to 2582e76 with no changes, split into three commits, so it can be squash-merged. It applies to
release/3.9.xwithout conflicts.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary.Issue reference
Backport of #13696 (KAG-5447)