1주차 미션 / 서버 4조 조규빈 #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGoo99
reviewed
Sep 20, 2024
JGoo99
left a comment
JGoo99
left a comment
There was a problem hiding this comment.
요구사항 구현, 범위 검증, 예외처리, 테스트 코드 모두 잘 수행해주셔서 크게 코멘트 할 부분이 없네요!
수고하셨습니다!
Comment on lines
+15
to
+18
| public void drawLine(int row, int position) { | ||
| if (!this.drawConfirm.confirm(row, position)) { | ||
| throw new IllegalArgumentException("Cannot Draw Line"); | ||
| } |
There was a problem hiding this comment.
confirm 메서드에 음수 검증이 따로 없는걸로 확인되는데 구현해주신 NaturalNumber 객체를 활용하여 drawLine 의 매개변수로 받으면 좋을 것 같아요.
지금은 매개변수로 -1 을 넣으면 예외가 발생합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
좀 더 객체를 사용해 보고 싶었는데 다음 주차에는 더 열심히 해보겠습니다!