2주차 미션 / 서버 2조 황정안 #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word in Row class
kmw10693
reviewed
Oct 1, 2024
| @@ -1,8 +1,76 @@ | |||
| public class Ladder { | |||
| Validation validation; | |||
There was a problem hiding this comment.
Validation은 private으로 접근 제어를 안하신 이유가 궁금하네요!
Comment on lines
+6
to
+7
| private final int RIGHT=1; | ||
| private final int LEFT=-1; |
Comment on lines
+5
to
+11
| if(naturalNumber<0){ | ||
| try { | ||
| throw new IllegalAccessException("Invalid deposit amount"); | ||
| } catch (IllegalAccessException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } |
Comment on lines
+5
to
+7
| public interface LadderCreator { | ||
| Row[] getRows(); | ||
| void drawLine(Position row, Position col); |
There was a problem hiding this comment.
디자인 패턴 중 팩터리 패턴을 공부해보시면 좋을 것 같습니다!
상위 클래스를 인터페이스나 추상 클래스로 지정하고, 하위 클래스에서 인스턴스를 만들지 결정하는 패턴입니다!
| GreaterThanOne numberOfPerson = GreaterThanOne.from(5); | ||
|
|
||
| //when | ||
| LadderUserCreator ladderUserCreator = new LadderUserCreator(numberOfRow, numberOfPerson); |
There was a problem hiding this comment.
객체지향적으로 봤을때, 이 코드는 구상 클래스에 의존하고 있는 코드입니다.
인터페이스가 아닌 특정 구현을 사용하게 되어버리는 것이죠!
LadderCreator ladderUserCreator = new LadderCreator(numberOfRow, numberOfperson)
이렇게 수정하는게 좋아보입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시간 내로 할 수 없을 것 같아 그냥 조금 더 천천히 고민 하고 올리고 싶어 지금 올리게 되었습니다.
기능은 다 구현 했으나, 리팩토링과 테스트 부분이 아쉬워 추후에 더욱 수정하여 다시 올리겠습니다!