Skip to content

fix: prevent long album titles from hiding song list - #580

Merged
temidaradev merged 2 commits into
Kopuz-org:masterfrom
diggingforce:fix-long-album-title
Aug 1, 2026
Merged

fix: prevent long album titles from hiding song list#580
temidaradev merged 2 commits into
Kopuz-org:masterfrom
diggingforce:fix-long-album-title

Conversation

@diggingforce

@diggingforce diggingforce commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

long album names caused the header to grow unbounded with shrink-0, hiding the entire song list

Added break-words line-clamp-3 to the <h1> so album name never goes past 3 lines

Fixes #575

Sanity Checking

  • I have read and followed the contribution guidelines.
  • My commits follow Kopuz's scoped commit convention and history hygiene rules.
  • I have disclosed any AI assistance as required by the AI policy in the contribution guidelines, or this pull request did not use AI assistance.
  • I have tested and self-reviewed my changes.

Style and Consistency

  • My changes are consistent with the existing crate boundaries and Dioxus style.
  • I ran cargo fmt --all --check or cargo fmt --all as appropriate.
  • I ran cargo clippy --workspace --all-targets -- -D warnings, or explained why it could not be run.
  • I kept generated assets, translations, and packaging files in sync when this change depends on them.

Testing

  • I ran the smallest relevant verifier for this change.
  • I documented any platform or verifier that I could not run.

Tested on platform(s):

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • Windows
  • Android
  • iOS

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The showcase header wrapper now supports flex shrinking, while album titles wrap words and clamp to three lines across Android and non-Android styles.

Changes

Showcase layout

Layer / File(s) Summary
Header sizing and title wrapping
crates/components/src/normal/showcase.rs
The header wrapper adds min-w-0, and the showcase title adds break-words and line-clamp-3 for both platform variants.

Suggested reviewers: temidaradev, notashelf, jomvick

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change limits long album headings and addresses issue #575's invisible song list problem.
Out of Scope Changes check ✅ Passed The patch only adjusts the showcase header layout and title wrapping, with no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly matches the main change: constraining long album titles so they no longer hide the song list.
Description check ✅ Passed The description is directly related to the change and accurately describes the album title overflow fix.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@temidaradev
temidaradev merged commit b139969 into Kopuz-org:master Aug 1, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Song list becomes invisible when the album name is too long (missing scrollbar)

2 participants