Skip to content

fullscreen: remember last tab when unhiding tabs in fullscreen mode - #585

Merged
temidaradev merged 2 commits into
Kopuz-org:masterfrom
skueee:save-tab-state-when-collapsing
Aug 1, 2026
Merged

fullscreen: remember last tab when unhiding tabs in fullscreen mode#585
temidaradev merged 2 commits into
Kopuz-org:masterfrom
skueee:save-tab-state-when-collapsing

Conversation

@skueee

@skueee skueee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Moved the active_tab variable from tabs.rs to desktop.rs so that its state is preserved when toggling the tabs panel.

AI Disclosure

I used Gemini 3.6 Flash (Web) to get a bit of help with git and to check if my English was correct as it is not my native language. I reviewed every change and command that the AI generated.

Sanity Checking

  • I have read and followed the contribution guidelines.
  • My commits follow Kopuz's scoped commit convention and history hygiene
    rules.
  • I have disclosed any AI assistance as required by the AI policy in the
    contribution guidelines, or this pull request did not use AI assistance.
  • I have tested and self-reviewed my changes.

Style and Consistency

  • My changes are consistent with the existing crate boundaries and Dioxus
    style.
  • I ran cargo fmt --all --check or cargo fmt --all as appropriate.
  • I ran cargo clippy --workspace --all-targets -- -D warnings, or
    explained why it could not be run.
  • I kept generated assets, translations, and packaging files in sync when
    this change depends on them.

Testing

  • I ran the smallest relevant verifier for this change.
  • I documented any platform or verifier that I could not run.

Tested on platform(s):

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • Windows
  • Android
  • iOS

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e80f3493-6ccd-4141-959b-ef728362a1b2

📥 Commits

Reviewing files that changed from the base of the PR and between 1d96fe0 and a0ba1d1.

📒 Files selected for processing (1)
  • crates/components/src/fullscreen/tabs.rs
💤 Files with no reviewable changes (1)
  • crates/components/src/fullscreen/tabs.rs

📝 Walkthrough

Walkthrough

FullscreenDesktop now owns the active tab signal and passes it to Tabs. Tabs uses the shared signal for tab selection and content rendering.

Changes

Fullscreen tab state

Layer / File(s) Summary
Lift active tab state into fullscreen desktop
crates/components/src/fullscreen/desktop.rs, crates/components/src/fullscreen/tabs.rs
FullscreenDesktop initializes and passes the active tab signal. Tabs accepts the signal for tab selection and content rendering.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes preserving the last active tab when the fullscreen tabs panel is shown again.
Description check ✅ Passed The description explains moving active_tab state to desktop.rs and documents testing and validation steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skueee

skueee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Current behavior :

2026-07-30.19-53-07.mp4

With the change :

2026-07-30.19-53-44.mp4

(forgot to upload that)

@skueee skueee changed the title various: remember last tab when unhiding in fullscreen mode fullscreen: remember last tab when unhiding tabs in fullscreen mode Aug 1, 2026
@temidaradev

Copy link
Copy Markdown
Member

do cargo fmt --all

@temidaradev
temidaradev merged commit e63d38a into Kopuz-org:master Aug 1, 2026
8 of 9 checks passed
@skueee
skueee deleted the save-tab-state-when-collapsing branch August 1, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants