Fix Meta Batch with format, remove wan factors #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComfyUI has added native latent factors for wan, so the ad hoc and particularly unhelpful factors I made can be pruned. Fix a missed scoping when checking that meta batch is compatible with a selected load format. Special thanks to tonirv68. This is still a bit clunkier than I would like and will likely see future updates. Resolves #409
Supporting formats on Meta Batches brings back an ugly problem of expecting users to do math. Restricting selections on the Meta Batch node would be an onerous amount of work, but as a simple solution, the closest valid frame is suggested when an error occurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.