Add a slave container configuration timeout #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage 19.49% 19.49%
Complexity 247 247
=========================================
Files 73 73
Lines 3027 3027
Branches 286 286
=========================================
Hits 590 590
Misses 2376 2376
Partials 61 61Continue to review full report at Codecov.
|
|
Should the same be added in windows script? |
This should fix the following issue. When a JobDSL seed job is executed while a container is waiting for its configuration YAD plugin may loose track of the container. The container is left behind indefinitely waiting for its configuration. With this change, the container eventually exit in error and the jenkins master is able to provision another container.
|
Yes, I think so! |
|
imho let's better add this value into UI settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following issue.
When a JobDSL seed job is executed while a container is waiting for its
configuration YAD plugin may loose track of the container.
The container is left behind indefinitely waiting for its configuration.
We are using the JobDSL plugin to generate multiple cloud sections in $JENKINS_HOME/config.xml
but the problem arise even when their is no change in the clouds configuration.
I imagine that when the seed job is executed it somehow reload the plugins and the container provisioning task is dropped in midflight.
The "Set exclusive execution" is set in our seed job but that doesn't prevent YAD from provisioning a container while a seed job is running (the provisioning task is not part of any job).
With this change, the container eventually exit in error and the jenkins
master is able to provision another container.
Environment:
Jenkins ver. 2.150.1
Job DSL plugin 1.70
Yet Another Docker Plugin 0.1.0-rc51