All except fix: Option 2 #1038
Merged
All except fix: Option 2 #1038
+721
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Jolanrensen
force-pushed
the
allexcept-npe-fix
branch
2 times, most recently
from
f539709 to
ade9f57
Compare
Jolanrensen
force-pushed
the
allexcept-npe-fix
branch
from
ade9f57 to
b101243
Compare
Jolanrensen
added
documentation
zaleslaw
reviewed
Feb 12, 2025
| df.select { name.except { firstNameAccessor } }, | ||
| df.select { name.except { firstName and firstName } }, | ||
| df.select { name.except { firstNameAccessor and firstNameAccessor } }, | ||
| // df.select { name.except(name.firstName and name.firstName) }, // not allowed |
There was a problem hiding this comment.
Looks like we need a test for this, but it's not possible in that manner and should be kind of tests for compiler plugin, when it's a String which should be compiled or not
There was a problem hiding this comment.
Or could we make assert on that?
There was a problem hiding this comment.
yes indeed, that's a good idea for later :)
zaleslaw
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761
NullPointerExceptionusingexceptto exclude double nested column #761exceptNew: Option 1 #1030@ExperimentalExceptCsDsland renamesexceptNewtoexcept@AccessApiOverloadfor KProperties and@ExcludeFromSourcesfor doc interfaces