Functions inline #1123
Merged
Functions inline #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 26, 2025 16:45
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/max.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/min.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/Utils.kt
Jolanrensen
reviewed
Apr 10, 2025
Jolanrensen
reviewed
Apr 10, 2025
Jolanrensen
reviewed
Apr 10, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/group.kt
Outdated
Show resolved
Hide resolved
Jolanrensen
reviewed
Apr 10, 2025
Jolanrensen
reviewed
Apr 10, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/describe.kt
Outdated
Show resolved
Hide resolved
|
So, now also closes #820. |
Jolanrensen
reviewed
Apr 10, 2025
| * __`.`__[**`into`**][GroupClause.into]**`(`**`groupName: `[`String`][String]**`)`** | ||
| * | ||
| * {@include [Indent]} | ||
| * __`.`__[**`into`**][GroupClause.into]**` { `**`groupNameExpression: `[`ColumnsSelector`][ColumnsSelector]**` } `** |
There was a problem hiding this comment.
This is not right, it's a different kind of function. First of all, it's not ColumnsSelector as that would allow selecting multiple columns. Second, it provides the original column (with path) as argument. Finally, you're allowed to return either a String or a column reference. It may be best to extract the definition for groupNameExpression to the top and explain the arguments and return types a bit more exact.
There was a problem hiding this comment.
Fixed now looks like this:
Jolanrensen
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group/ungroup#820.