Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1221
Uses this PR as its base: #663:
But it's now up-to-date and contains some refactoring:
CodeWithConverter
->CodeWithTypeCastGenerator
. It was never really a "converter", it can just generate a casting expression for an expression, so...TypeCastGenerator
interface (the name can still change of course). It has a specific implementation that uses thecast<>()
functions from the DataFrame API (instead of having string literals in different places) which also supports multiple type-arguments (for GroupBy).markerName
->targetTypeName
since it makes it easier to understand without a grasp of the larger context.