Handling Chars as Strings implicitly #999
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #998
This PR can best be reviewed per-commit. It contains 3 parts where we can enhance Char support:
The first commit adds String-fallback for Char columns to
df.convert()...andcharCol.convertTo<X>(). This means you can now do things likeConverting Char -> Int remains unchanged, it takes the char code instead of the value, similar to casting a char to int in java.
The second commit adds "treating chars as strings" behavior to the
df.convertTo<Schema> {}DSL. This makes the behavior mentioned in #998 possible again:This we could change to
charParser {}andparser {}separately if we wish so. It's still up for debate.The third commit introduces parsing of
Charcolumns, similar to String columns.This means you can now do:
and
Charcolumns will also be considered when callingDataFrame.parse().I still need to update the docs, but first I want to be sure there are not other places that could benefit from this Char-as-String treatment.