feat: reworked footer according to new UI #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezinant
force-pushed
the
ktl-1696-footer
branch
3 times, most recently
from
57567bc to
c37f669
Compare
berezinant
force-pushed
the
ktl-1696-footer
branch
from
c37f669 to
c4a8ebf
Compare
berezinant
force-pushed
the
ktl-1696-footer
branch
2 times, most recently
from
5cc855c to
0b58a9c
Compare
berezinant
force-pushed
the
ktl-1696-footer
branch
from
0b58a9c to
974340b
Compare
berezinant
force-pushed
the
ktl-1696-footer
branch
from
974340b to
65680a7
Compare
krutilov
reviewed
Jan 21, 2025
| @@ -13,7 +13,7 @@ tasks.withType<AbstractDokkaTask>().configureEach { | |||
| @Language("JSON") | |||
| val dokkaBaseConfiguration = """ | |||
| { | |||
| "footerMessage": "(c) 2024 My custom footer message", | |||
| "footerMessage": "<div class='kt-footer__license'>Kotlin™ is protected under the <a href='https://kotlinlang.org/foundation/kotlin-foundation.html' data-test='external-link ' target='_blank' rel='noreferrer noopener' class='kt-footer__link'>Kotlin Foundation</a> and licensed under the <a href='https://github.com/JetBrains/kotlin-web-site/blob/master/LICENSE' data-test='external-link ' target='_blank' rel='noreferrer noopener' class='kt-footer__link'>Apache 2 license</a>. </div>", | |||
There was a problem hiding this comment.
Not sure about having full markup here. Is there any other place to put this template?
There was a problem hiding this comment.
Or it's a test snapsthot?
There was a problem hiding this comment.
Or it's a test snapsthot?
Yes, this is a more complex example of footer customisation for our testing purposes
berezinant
force-pushed
the
ktl-1696-footer
branch
from
65680a7 to
04bf572
Compare
berezinant
force-pushed
the
ktl-1696-footer
branch
from
04bf572 to
1d2c594
Compare
krutilov
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks like
and this is an example with a custom content