Implement parsing and formatting for Instant as separate functions#411
Closed
dkhalanskyjb wants to merge 6 commits into
Closed
Implement parsing and formatting for Instant as separate functions#411dkhalanskyjb wants to merge 6 commits into
dkhalanskyjb wants to merge 6 commits into
Conversation
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
71fc711 to
fd78536
Compare
ilya-g
reviewed
Oct 30, 2024
Comment on lines
+173
to
+175
| total += (y + 3) / 4 - (y + 99) / 100 + (y + 399) / 400 | ||
| } else { | ||
| total -= y / -4 - y / -100 + y / -400 |
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
fd78536 to
019c71b
Compare
dkhalanskyjb
changed the title
dkhalanskyjb
commented
Nov 7, 2024
Comment on lines
+401
to
+409
| private fun parseInstant(isoString: String): Instant { | ||
| // return Instant.parse(isoString) | ||
| return parseIso(isoString) | ||
| } | ||
|
|
||
| private fun displayInstant(instant: Instant): String { | ||
| // return instant.toString() | ||
| return formatIso(instant) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@qurbonzoda, here's the logic behind this PR: the newly-added formatIso can replace toString, and the newly-added parseIso can replace Instant.parse in the case when no specific format is passed (which is the only case supported by `kotlin.time.Instant).
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
023b7ac to
ece4e11
Compare
ilya-g
reviewed
Dec 3, 2024
| expect("'T' or 't'", i + 6) { it == 'T' || it == 't' } | ||
| expect("':'", i + 9) { it == ':' } | ||
| expect("':'", i + 12) { it == ':' } | ||
| for (j in listOf(1, 2, 4, 5, 7, 8, 10, 11, 13, 14)) { |
Member
There was a problem hiding this comment.
Better to extract such index lists to variables outside the function and (optionally) make them arrays.
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
f77c2a0 to
3de6ba9
Compare
qurbonzoda
reviewed
Dec 11, 2024
| override fun toString(): String = "UnboundedLocalDateTime($year-$month-$day $hour:$minute:$second.$nanosecond)" | ||
|
|
||
| companion object { | ||
| fun fromInstant(instant: Instant, offsetSeconds: Int): UnboundedLocalDateTime { |
Contributor
There was a problem hiding this comment.
There is only one call to this function, and it passes 0 for offsetSeconds.
Collaborator
Author
There was a problem hiding this comment.
Yes. Do you see any problems with that?
qurbonzoda
reviewed
Dec 11, 2024
| fun parseFailure(error: String): Nothing { | ||
| throw IllegalArgumentException("$error when parsing an Instant from $isoString") | ||
| } | ||
| inline fun expect(what: String, where: Int, predicate: (Char) -> Boolean) { |
Contributor
There was a problem hiding this comment.
Local inline functions are not yet supported.
Collaborator
Author
There was a problem hiding this comment.
When I build the project or open it in the IDE, I receive no such error/warning.
dkhalanskyjb
force-pushed
the
uniform-ranges
branch
from
c01263f to
5882b5c
Compare
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
4c4e638 to
70469f0
Compare
Collaborator
Author
|
This code is in some form already in Kotlin's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement parsing and formatting of ISO strings for instant values separately from the rest of the library.
A stage of fixing #382
This is a draft PR because we probably don't need to actually merge it into the datetime library. However, the code is already written and can be reviewed.