Class discriminator conflict check rework #3105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- from JsonNamingStrategy - from ALL_JSON_OBJECTS - from default polymorphic serializer Changed the type of thrown exception to SerializationException because it is our contract for .encodeToString. Stop recommending array polymorphism because it is outdated.
now it is allowed to have a conflicting name on deserialization, conflicts are reported only during encoding.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check more potential places where conflict can occur during encoding:
Allow regular polymorphic classes to be decoded with conflicting names because this is our behavior for sealed classes.