Skip to content

Commit

Permalink
FIX: Small memory leak
Browse files Browse the repository at this point in the history
  • Loading branch information
paulov-t committed Aug 18, 2022
1 parent ea7aeeb commit 29afaf3
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions core/util/utility.js
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,12 @@ exports.generateNewId = (prefix = "", version = 2) => {
}

var previousItemIds = [];
var previousItemIdsGenerationTime = Date.now();

exports.generateNewIdQuick = () =>
{


let new_id = "";
const first = this.getRandomInt(100000, 999999).toString();
while(new_id.length < 24)
Expand All @@ -458,12 +461,12 @@ exports.generateNewIdQuick = () =>
new_id = new_id.concat(first.split("").reverse().join(""));
}
new_id = new_id.substring(0, 24);
if(previousItemIds.findIndex(x=>x === new_id) === -1) {
previousItemIds.push(new_id);
}
else {
return this.generateNewIdQuick();
}
// if(previousItemIds.findIndex(x=>x === new_id) === -1) {
// previousItemIds.push(new_id);
// }
// else {
// return this.generateNewIdQuick();
// }
return new_id;
}

Expand Down

0 comments on commit 29afaf3

Please sign in to comment.