migrate oauth2 into upstream #1689
Conversation
| req_params = { | ||
| "username": login, | ||
| "password": password, | ||
| "grant_type": "password", |
There was a problem hiding this comment.
This password grant type is rarely enabled, so this is will usually not work.
Instead, the client app sends the user to an auth page in the browser, which returns an authCode, then the app uses the OAuth server to change that auth code into an access token and refresh token, and then the app passes the access token to the app server (radicale). The app server only needs to check whether the access token is valid.
There was a problem hiding this comment.
I would have assumed this already, see my comments in the discussions...if one really want to have OAuth2 inside radicale and not terminating on reverse proxy in front of, further code contribution is required (incl. all the error handling).
PR(s) are welcome!
taken from https://gitlab.mim-libre.fr/alphabet/radicale_oauth/-/blob/dev/oauth2/ with adjustments
supports #1359