-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][MPI] Adding SpecializedSpatialSearchMPI
class, which provides MPI interface to SpecializedSpatialSearch
#11305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready @pooyan-dadvand |
@roigcarlo why FullDebug GCC Ci is not even running? |
It runs. but fulldebug is the longest queue, if there are many PR running it could be delayed quite a lot... |
Closing as included in #11719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Following the implementation detailed in #11205, this Pull Request introduces
SpecializedSpatialSearchMPI
. This new feature operates similarly toSpecializedSpatialSearch
, but with added compatibility for MPI. Please note that this feature can only be used in conjunction with the container from PR #11205.SpecializedSpatialSearchMPI
functions by establishing local searches using aSpecializedSpatialSearch
within each partition. Leveraging the containers defined in PR #11205, the solution is then synchronized across all partitions. This approach ensures efficient and consistent data sharing in a distributed computing environment.Similar to #11224, but for
SpecializedSpatialSearch
. In fact there are common changes and probably some conflict will appear once one of them is merged.TODO: Implement asynchronous version (I will add it to this PR, but I open the PR now, so I can easily track myself)
🆕 Changelog
SpecializedSpatialSearchMPI
viakratos/mpi/spatial_containers/specialized_spatial_search_mpi.cpp
SpecializedSpatialSearchMPIFactory
viakratos/mpi/spatial_containers/specialized_spatial_search_mpi_factory.h
kratos/mpi/python/add_mpi_search_strategies_to_python.cpp
MPISearchUtilities
#11247SpatialSearchResultContainerMap
toSpatialSearch
#11243SpatialSearchResultContainer
andSpatialSearchResultContainerMap
#11205SpatialSearch
#11244