-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][MPI] Adding SpatialSearchResultContainer
/SpatialSearchResultContainerVector
and SearchWrapper
(v.3.0)
#11719
Open
loumalouomega
wants to merge
588
commits into
master
Choose a base branch
from
core/mpi/spatial-search-container-new-proposal-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,556
−21
Open
Changes from 250 commits
Commits
Show all changes
588 commits
Select commit
Hold shift + click to select a range
4de7430
Adding checks
loumalouomega 998b350
Missing return
loumalouomega 008e378
Refactor
loumalouomega 7541337
Missing return
loumalouomega c49c462
Refactor
loumalouomega 73ab997
Missing
loumalouomega c2ea227
Missing
loumalouomega e626b9b
Fix empty cases
loumalouomega 75fe1e3
Fix empty cases
loumalouomega 4c46d47
Refactor `SpatialSearchResultContainer`
loumalouomega 3c79e77
Refactor `SpatialSearchResultContainerVector` (WIP)
loumalouomega edb1f82
Update `SpatialSearchResultContainer` tests
loumalouomega 7def12a
Update `SpatialSearchResultContainerVector` tests
loumalouomega ad4f520
Refactor `SearchWrapper`
loumalouomega 554bfb5
Expose new and missing methods
loumalouomega 449deba
Update MPI test
loumalouomega 48741b2
Refactor tests
loumalouomega b177ce1
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 2bab9dc
Remove maps, pure vectors, suggested interface by @pooyan-dadvand
loumalouomega 5bc04f0
Temporal cleaning
loumalouomega 97a518d
Adding debug error
loumalouomega 82cc503
Adding missing check required by @jcotela
loumalouomega f34aed9
Correction
loumalouomega 84bd0fa
Fix MPI run
loumalouomega 54381ff
Adding test to verify properly works
loumalouomega 74af7ef
Prepare
loumalouomega 0a51cf2
Some fixes
loumalouomega 90f1eda
Some additional info added
loumalouomega d947bbc
Partial revert
loumalouomega 9befaf5
Adding more info
loumalouomega ba413c0
Adding `IsLocalSearch` method
loumalouomega 619e7cf
Merge branch 'master' into core/modify-spatial-search-result-containe…
loumalouomega a9fe0c3
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 26a9268
Adding more info
loumalouomega 5eb193a
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 45ca399
Better check
loumalouomega 5ca5bb6
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 6b09f72
Extend checks
loumalouomega 9c66116
Some function refactor, more check
loumalouomega cf4ac60
Correct the test suite
loumalouomega 670977b
More generic
loumalouomega b4921c2
More generic
loumalouomega 367b576
Update
loumalouomega 82a5056
Update
loumalouomega ce24937
Missing
loumalouomega 314ee43
Missing
loumalouomega ba8f15e
Refactor assign
loumalouomega 69aa2ce
Fix clang compilation
loumalouomega aafd999
Unrequired definition
loumalouomega 4aacb1d
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 3ea9845
Update kratos/utilities/search_utilities.h
loumalouomega 51ddc4b
Update kratos/utilities/search_utilities.h
loumalouomega c7d506a
Merge branch 'master' into core/modify-spatial-search-result-containe…
loumalouomega e7bcb20
Update kratos/utilities/search_utilities.h
loumalouomega 8d00cc3
Update kratos/utilities/search_utilities.h
loumalouomega 6969d21
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 845c2c7
Update
loumalouomega 6aea813
Recommendation
loumalouomega f638046
Suggestion by @roigcarlo
loumalouomega 2629c5b
Recommendation
loumalouomega 8ff08ef
Suggestion by @roigcarlo
loumalouomega 59f6c5b
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 026e80b
Merge branch 'master' into core/modify-spatial-search-result-containe…
loumalouomega 4d80957
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 7515759
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega c2456a6
Merge branch 'master' into core/modify-spatial-search-result-containe…
loumalouomega 82eb6ef
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega e2221dc
Minor
loumalouomega a9d7f2e
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega d7561ac
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega b975e68
Some modification in SearchUtilities to accommodate the requirements …
loumalouomega 48f1674
Adding Barrier method, as well as separate global and local index
loumalouomega a71dc42
Update consistently SearchWrapper
loumalouomega dc795fc
Simplification
loumalouomega e8f730d
Minor test update
loumalouomega b49017f
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 6e6f9ae
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 6cc9d45
Improve check
loumalouomega cde548f
Merge pull request #11857 from KratosMultiphysics/core/modify-spatial…
loumalouomega 84fccc3
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 44ffe00
Minor
loumalouomega c5bdfb2
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega c3ed537
Consistent Rank
loumalouomega c5bf9fc
Fix
loumalouomega e353b61
Adding timers
loumalouomega c757642
Search ranks is a redundant information
loumalouomega 10d55d8
Missing check (reduces sending/receiving info)
loumalouomega d8b76cf
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega bc22e90
[Core] Missing & in `Get` method in `SpatialSearchResult`
loumalouomega 72c87bc
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega b3fa630
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega cf4113e
[Core] Correcting corner case in `GeometricalObjectBins` + typo ("ava…
loumalouomega e11e0ff
Minor clean up
loumalouomega 73829d9
Revert
loumalouomega ba4f67c
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 3e103dd
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 4c3678f
Fix potential node conflict
loumalouomega 3a54ce5
Update search utilities
loumalouomega f8a029d
Update the SpatialSearchResultContainer adding SpatialSearchCommunica…
loumalouomega 8ff6850
Update the SpatialSearchResultContainerVector adding SpatialSearchCom…
loumalouomega d4e5cdc
Update the SearchWrapper consistently
loumalouomega a3ec6bb
Update python exposition
loumalouomega af04564
Serial compilation fix
loumalouomega 4e5df90
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega a2d2794
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 9ecf8b3
Adding `GetSpatialSearchCommunication`
loumalouomega a63a0fc
Update tests
loumalouomega 8f4dd45
Adding error
loumalouomega 9838922
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 6b36995
Adding error
loumalouomega 119cce7
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 9109f27
Minor fix
loumalouomega d60f1bf
Minor fix
loumalouomega 5987400
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 96c767e
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 88b1dfa
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 6f62ac6
Adding `RemoveResultsFromRanksList`
loumalouomega 3203640
Update `KeepOnlyGivenLambdaResult` with ranks
loumalouomega 667de5b
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 2eee44a
Adding `RemoveResultsFromRanksList`
loumalouomega 96c7a54
Update `KeepOnlyGivenLambdaResult` with ranks
loumalouomega 777bb8f
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 6feebe0
Extra :
loumalouomega 014d1bb
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega aae224f
Fix Windows communicator issue
loumalouomega 70021c2
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 6d4ee58
Improve logic
loumalouomega 63a6abd
Improve logic
loumalouomega 8b97858
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 8d8a89c
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 990d9ed
Update `PreparePointsSearch` with Rank info
loumalouomega aba08bc
Add rank in `PreparePointsSearch` call
loumalouomega a55e460
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 2944fdd
Update `PreparePointsSearch` with Rank info
loumalouomega 2d84ce2
Add rank in `PreparePointsSearch` call
loumalouomega bfd38ec
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega e03cc1d
work in progress
AFranci 886f748
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega ecf62c6
work in progress
AFranci 10c310e
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 3b2dcc0
Minor checks done when filling
loumalouomega 2c244a1
Add additional checks
loumalouomega f4901cd
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 7047001
Add additional checks
loumalouomega 8563e29
Minor checks done when filling
loumalouomega 6b0bb35
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega f72a9e5
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 99dcd01
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 1e5c34a
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega 68115ee
Merge pull request #12024 from KratosMultiphysics/core/mpi/spatial-se…
loumalouomega 5916649
Update test_edge_based_data_structure.cpp
rubenzorrilla a675438
Adding linear to quadratic tets modeler
jcotela b6116a8
Adding doc
loumalouomega 635e042
Expose GeometryData to Python
jcotela 5a44734
Use GeometryType to filter incorrect input
jcotela 43a91c7
Class rename
jcotela 17ad216
Adding python registry to MeshingApplication
jcotela 653d99e
Install python registry file
jcotela 32d942a
Fixing registry
jcotela 810112c
Add tests
jcotela 3be58a6
Removing factory method
jcotela 02baedc
Revert unwanted change in output level
jcotela 7d99473
Minor updates
jcotela 2147ee5
Using any
jcotela 48faca5
Require root model part
jcotela 4b12221
Cleaning up
jcotela cc5ff62
Avoid element copy
jcotela 09eecac
Add condition check
jcotela d76c637
Fix wrong check
jcotela 686dd8d
Remove duplicate check
jcotela e82f5cc
Update applications/MeshingApplication/custom_utilities/linear_to_qua…
jcotela 7ed5b2b
Update applications/MeshingApplication/custom_utilities/linear_to_qua…
jcotela 10ee600
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega b947bee
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega ff954d3
Unify serial and distributed
loumalouomega 573e408
Some remaining changes
loumalouomega 16653f4
Inconsistent
loumalouomega 5e19156
Clean up and unify code
loumalouomega 02b3e94
Unnecesary serial fix
loumalouomega 927c820
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 29d2fc5
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 3687bba
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 02ea856
1st cut-fem
AFranci 2dc15e5
Set 10 to default `bucket_size`
loumalouomega 428f04d
Clarify global BB
loumalouomega f4fffa7
Wrong description
loumalouomega 9ab0417
Using vectorial version
loumalouomega 82ef541
Clarify doc
loumalouomega 9c002b0
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega b3b86b0
Check already done in `Apply`
loumalouomega 6d70719
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega adc1476
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 124be55
Minor
loumalouomega 318abab
Some missing stuff
loumalouomega d4c9d02
Minor correction
loumalouomega f401e2b
Add new methods and variables to the SpatialSearchResultContainerVect…
loumalouomega eb6e33b
Add missing methods and variables to the SpatialSearchResultContainer…
loumalouomega a9f19ce
Add new test cases to SpatialSearchResultContainerVector class
loumalouomega d53aee0
Add new MPI test cases to SpatialSearchResultContainerVector class
loumalouomega bb452b7
Fix compilation unsigned issue
loumalouomega dd7cffc
Compilation fix
loumalouomega 6a23f7d
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega bcad3fc
Add GetGlobalIndex and SetGlobalIndex methods to SpatialSearchResultC…
loumalouomega ffe1312
Adding more extended and complex search test
loumalouomega e9b668d
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 0fad27f
[Core] Fix BB check
loumalouomega 655214a
Extend test (WIP)
loumalouomega b3818a3
Fix index
loumalouomega c8bbe65
Activate test MPI
loumalouomega 4cb4066
Add tests for PointIsInsideBoundingBox functions
loumalouomega 058087a
Refactor search_wrapper.h to use zero instead of -1 for non-distribut…
loumalouomega b0338f2
[Core] Refactor search_utilities.h to handle negative tolerance value…
loumalouomega f5f8944
Refactor search_wrapper.h to use consistent bounding box threshold value
loumalouomega e65c432
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega f324df5
Refactor search_wrapper.h to use consistent bounding box threshold value
loumalouomega 59aea26
Refactor search_wrapper.h to use consistent bounding box threshold value
loumalouomega 23eb0b3
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 87fdd9b
Merge branch 'master' into doc/document-search-mpi
loumalouomega a11aa71
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega ce164ac
Merge branch 'master' into doc/document-search-mpi
loumalouomega 0bef7e1
Remove whitespace
loumalouomega afdba02
Document tree
loumalouomega 267685a
Document spatial search result
loumalouomega 48111fd
Document octree
loumalouomega b936bae
Document kd_tree
loumalouomega ff31cf0
Document bins static
loumalouomega bd47b60
Document bins dynamic
loumalouomega a9ceb62
Document GeometricalObjectsBins
loumalouomega ef3af98
Point to wiki
loumalouomega 5926add
Remove images
loumalouomega e1094e9
Merge branch 'doc/initial-search-doc' into doc/document-search-mpi
loumalouomega 77f1df7
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 403d792
Merge branch 'master' into doc/document-search-mpi
loumalouomega 89aa204
Delete duplicated doc
loumalouomega 37d9391
[Core] Adding documentation for MPI classes
loumalouomega e393e73
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 3c29117
Merge branch 'core/mpi/spatial-search-container-new-proposal-v3' into…
loumalouomega f78191c
Merge pull request #12480 from KratosMultiphysics/doc/document-search…
loumalouomega 1cd8c19
Minor doc update
loumalouomega 8fc59ae
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega b8badaf
Update the includes
loumalouomega 854466e
Deactivate hetereogeneous tests
loumalouomega 7b1d86e
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega f5984de
Cleanup subdatacommunicators in SearchWrapper destructor
loumalouomega d45c5f2
Redundant
loumalouomega 7a52876
Reactivate hetereogeneous tests
loumalouomega 4ad9e07
Simplify code with data communicator implementation
loumalouomega 9443276
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega e6a1223
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega 74320c8
Merge branch 'master' into core/mpi/spatial-search-container-new-prop…
loumalouomega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be sure:
the data_communicator changes being reviewed in a different PR, am i correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#11712