[GeoMechanicsApplication] GetVariableBasedOnString is now emitting a warning rather than an error in set_parameter_field_process #13011
+70
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronnoordam
changed the title
rfaasse
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Thank you for addressing this issue and adding clear tests! I have an idea for a different solution which would require less code changes if I understand the issue correctly. Let me know what you think!
I think it is a good idea anyway though to rename the branch to geo/ such that the TC and sonarcloud pipelines also run.
|
|
||
| # Check that a warning was raised | ||
| assert len(w) == 1 | ||
| assert issubclass(w[-1].category, UserWarning) |
There was a problem hiding this comment.
We've had some issues in the past that sonarcloud doesn't recognize the assert and therefore could flag the indexging w[-1] as a 'reliability' issue. Would it be possible to rename this branch to geo/ such that the sonarcloud analysis as well as other pipelines will be run? E.g. github doesn't run the validation tests (only small/nightly)
applications/GeoMechanicsApplication/python_scripts/set_parameter_field_process.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetVariableBasedOnString is now emiting a warning rather than an error in set_parameter_field_process
Before, an error was emited when a variable like DENSITY_SOLID, which is not exported tot the python api, is requested
this error is only required when wanting to generate a parameter field with a python function
But the function which raises the error is still required in the init