Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Removed initialization of material response from InitializeSolutionStep #13027

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Jan 21, 2025

📝 Description
In PR #13014, initialization of material response has been added to the element initialization. Previously, that was done by the initialization of the solution step. It was, however, not removed there. Now it has been.

…tep`

In [PR #13014](#13014), initialization of material response has been added to the element initialization. Previously, that was done by the initialization of the solution step. It was, however, not removed there. Now it has been.
@avdg81 avdg81 added Cleanup GeoMechanics Issues related to the GeoMechanicsApplication labels Jan 21, 2025
@avdg81 avdg81 requested review from rfaasse and WPK4FEM January 21, 2025 15:53
@avdg81 avdg81 self-assigned this Jan 21, 2025
Data member `mIsInitialised` was no longer needed, since the implicit assumption of class `UPwBaseElement` is that member function `Initialize` must be called prior to calling `InitializeSolutionStep`.

A handful of unit tests lacked the call to `Initialize` prior to calling `InitializeSolutionStep`, and therefore started to fail. Those tests have been fixed now.
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a consistent removal to me. Initialize is always invoked. The transient Pw element test has been made consistent with the intention of the code setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup GeoMechanics Issues related to the GeoMechanicsApplication
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Fix the displacement Dirichlet boundary condition
2 participants