Claude/audit ps2 spsc 20260731 - #454
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caa41d2b48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| asm volatile("pause" ::: "memory"); | ||
| } | ||
| KLOG_WARN("drivers/virtio/rng", "entropy poll timed out"); | ||
| mm::FreeFrame(buf_phys); |
There was a problem hiding this comment.
Keep timed-out RNG DMA buffers pinned
If the virtio-rng request does not complete within this CPU spin budget, timing out does not cancel the descriptor or reset the queue, so the device may still own and later write to buf_phys. Returning this frame to the allocator allows a delayed completion to DMA entropy into an unrelated page that has since been reallocated, corrupting kernel memory; retain the frame until the descriptor is reclaimed or reset/drain the queue before freeing it.
Useful? React with 👍 / 👎.
qemu-smoke —
|
qemu-smoke —
|
qemu-smoke —
|
qemu-smoke —
|
qemu-smoke —
|
qemu-smoke —
|
qemu-smoke —
|
Signed-off-by: Krill <natew94@gmail.com>
…sion Nathan-933] Signed-off-by: Krill <natew94@gmail.com>
…an-1840] Signed-off-by: Krill <natew94@gmail.com>
…Nathan-596] Signed-off-by: Krill <natew94@gmail.com>
…ssion Nathan-1403] Signed-off-by: Krill <natew94@gmail.com>
…session Nathan-265] Signed-off-by: Krill <natew94@gmail.com>
…ssion Nathan-83] Signed-off-by: Krill <natew94@gmail.com>
… Nathan-949] Signed-off-by: Krill <natew94@gmail.com>
…ession Nathan-1354] Signed-off-by: Krill <natew94@gmail.com>
… Nathan-2013] Signed-off-by: Krill <natew94@gmail.com>
…on Nathan-1325] Signed-off-by: Krill <natew94@gmail.com>
…ssion Nathan-1474] Signed-off-by: Krill <natew94@gmail.com>
…tem [session Nathan-281] Signed-off-by: Krill <natew94@gmail.com>
…Nathan-252] Signed-off-by: Krill <natew94@gmail.com>
…than-2412] Signed-off-by: Krill <natew94@gmail.com>
…' [session Codex-Root-EndpointContract-20260802] Signed-off-by: Krill <natew94@gmail.com>
…an-1615] Signed-off-by: Krill <natew94@gmail.com>
…em [session Codex-Root-EndpointContract-20260802] Signed-off-by: Krill <natew94@gmail.com>
…ession Nathan-826] Signed-off-by: Krill <natew94@gmail.com>
…ession Nathan-914] Signed-off-by: Krill <natew94@gmail.com>
…2' [session Nathan-984] Signed-off-by: Krill <natew94@gmail.com>
…sion Nathan-1080] Signed-off-by: Krill <natew94@gmail.com>
…ion Codex-PcnetVirtioRestart-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…sion Nathan-61] Signed-off-by: Krill <natew94@gmail.com>
…60802' [session Codex-ServiceTeardownContract-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…bsystem [session Codex-ServiceTeardownContract-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
…ion Nathan-647] Signed-off-by: Krill <natew94@gmail.com>
…02' [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
… [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…ssion Nathan-95] Signed-off-by: Krill <natew94@gmail.com>
… [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
…session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
…' [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
…0260802' [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
…2' [session Codex-ProcessLifecycle-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…sion Codex-PcnetVirtioRestart-Recovery-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…sion Nathan-386] Signed-off-by: Krill <natew94@gmail.com>
…n Nathan-1703] Signed-off-by: Krill <natew94@gmail.com>
…session Nathan-1851] Signed-off-by: Krill <natew94@gmail.com>
…sion Codex-ArpCopyoutConsumers-20260802] Signed-off-by: Krill <natew94@gmail.com>
Signed-off-by: Krill <natew94@gmail.com>
…ssion Codex-ArpCopyoutConsumers-20260802] Signed-off-by: Krill <natew94@gmail.com>
No description provided.