Open
fix: Align PdfVerifier contract with actual SP1 circuit output and add forge verify-contract docs#12
Conversation
…-contract docs Co-authored-by: Kushmanmb <193178375+Kushmanmb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify contract implementation for correctness
fix: Align PdfVerifier contract with actual SP1 circuit output and add forge verify-contract docs
Mar 11, 2026
Kushmanmb
approved these changes
Mar 11, 2026
Kushmanmb
marked this pull request as ready for review
March 11, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfVerifier.solwas out of sync with the zkPDF circuit's actual public values struct, causing broken tests and an unusable contract. Theplonk-fixture.jsonhad been left as a Fibonacci example from a template.Contract (
PdfVerifier.sol)PublicValuesStruct: Replaced stubbool resultwith the correct fields matchingcircuits/lib/src/types.rs:verifyPdfProof: Return type changed frombooltoPublicValuesStruct memory, returning the full decoded public values instead of a single flag.Fixtures
plonk-fixture.json: Replaced Fibonacci template data with correct zkPDF public values (proper ABI-encodedPublicValuesStruct) and a plonk-specific vkey.Docs (
contracts/README.md)forge verify-contract, includingcast abi-encodefor constructor args encoding.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.