Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove dry-run from OSP-related CI workflows #777

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

elliotxx
Copy link
Collaborator

@elliotxx elliotxx commented Feb 6, 2025

What type of PR is this?

/kind chore

What this PR does / why we need it:

Tested without any problems, officially enabled OSP automatic updates (Planning and Community Tasks).

This PR removes the --dry-run option from OSP-related CI workflows:

  • Removes --dry-run from the community planning workflow
  • Removes --dry-run from the community task workflow

The workflows will now make live changes as originally intended. The --dry-run option was likely used for testing and is no longer necessary.

Which issue(s) this PR fixes:

Fixes #

- Remove `--dry-run` from community planning workflow
- Remove `--dry-run` from community task workflow

This reverts the workflows to their original behavior where they make live changes. The `--dry-run` option was likely used for testing purposes and is no longer needed.
@elliotxx elliotxx added this to the v0.7.0 milestone Feb 6, 2025
@elliotxx elliotxx self-assigned this Feb 6, 2025
Copy link
Collaborator

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit f86e53e into main Feb 6, 2025
11 of 13 checks passed
@adohe adohe deleted the remove-dry-run branch February 6, 2025 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants