Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a util to self sign cert and update to WebhookConfiguration #52

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

wu8685
Copy link
Collaborator

@wu8685 wu8685 commented Jul 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wu8685 wu8685 force-pushed the webhook-self-sign-cert-util branch 2 times, most recently from 075a57f to f1b0ab0 Compare July 6, 2024 08:07
@wu8685 wu8685 force-pushed the webhook-self-sign-cert-util branch from f1b0ab0 to 3c18bf7 Compare July 6, 2024 08:16
@wu8685 wu8685 requested a review from zoumo July 6, 2024 08:27
webhook/cert/fs.go Outdated Show resolved Hide resolved
webhook/cert/signer.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@zoumo zoumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoumo zoumo merged commit 5f666d4 into KusionStack:main Jul 8, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants