Skip to content

feat: handle empty stack in preview #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

It is actually valid to pass an empty spec for a preview, and Kusion should handle the preview result correctly.
This change should not affect how apply and destroy handle an empty spec.

Which issue(s) this PR fixes:

Fixes #1419

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Apr 24, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@7h3-3mp7y-m4n
Copy link
Contributor Author

And the CI failed!
I'll fix it ASAP!

@ruquanzhao ruquanzhao changed the title feat: Handel empty stack in preview feat: handle empty stack in preview Apr 25, 2025
@ruquanzhao ruquanzhao added this to the v0.15.0 milestone Apr 25, 2025
@ruquanzhao ruquanzhao self-requested a review April 25, 2025 03:45
@ruquanzhao
Copy link
Collaborator

And the CI failed! I'll fix it ASAP!

Please ignore Check Markdown links and e2e test, there are some bugs.

And Constraints / Commit Lint (pull_request) is about your commit message, rewrite to feat: handle empty stack in preview will fix it.

@ruquanzhao
Copy link
Collaborator

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@7h3-3mp7y-m4n By the way, you need to sign the CLA according to the description here, otherwise the PR will not be accepted. 😃

@KusionStack KusionStack deleted a comment from coveralls Apr 25, 2025
@7h3-3mp7y-m4n
Copy link
Contributor Author

And the CI failed! I'll fix it ASAP!

Please ignore Check Markdown links and e2e test, there are some bugs.

And Constraints / Commit Lint (pull_request) is about your commit message, rewrite to feat: handle empty stack in preview will fix it.

I see, yeah I'll change it and also sign the CLA :)

@7h3-3mp7y-m4n
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ruquanzhao ruquanzhao merged commit bd7c55f into KusionStack:main May 2, 2025
6 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
@ruquanzhao
Copy link
Collaborator

Thanks! @7h3-3mp7y-m4n👏👏👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion should correctly handle empty spec in preview
2 participants