feat: update reserves calculation for uniswap-v4/pancake-cl pools #1223
+85
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage changes:
|
NgoKimPhu
reviewed
Dec 18, 2025
| l.WithFields(logger.Fields{ | ||
| "error": err, | ||
| }).Error("failed to calculate reserves from ticks") | ||
| return entity.Pool{}, err |
NgoKimPhu
reviewed
Dec 18, 2025
Comment on lines
+44
to
+50
| tickUpper := ticks[i+1] | ||
|
|
||
| sqrtLower, err := utils.GetSqrtRatioAtTick(tickLower.Index) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| sqrtUpper, err := utils.GetSqrtRatioAtTick(tickUpper.Index) |
Member
There was a problem hiding this comment.
can micro optimize this to reduce GetSqrtRatioAtTick calls by 2
NgoKimPhu
reviewed
Dec 18, 2025
Comment on lines
+56
to
+65
| if sqrtPriceX96.Cmp(sqrtLower) < 0 { | ||
| numer.Mul(L, Q96).Mul(&numer, tmp.Sub(sqrtUpper, sqrtLower)) | ||
| denom.Mul(sqrtLower, sqrtUpper) | ||
|
|
||
| amount0.Div(&numer, &denom) | ||
| } else if sqrtPriceX96.Cmp(sqrtUpper) >= 0 { | ||
| numer.Mul(L, tmp.Sub(sqrtUpper, sqrtLower)) | ||
|
|
||
| amount1.Div(&numer, Q96) | ||
| } else { |
Member
There was a problem hiding this comment.
can also micro-optimize this to reduce Cmp (since sqrtLower is in increasing order) (and totalAmountX.Add)
Member
There was a problem hiding this comment.
this code is in quite hot path so just trying to optimize bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):