fix: remove hardcoded date from runtime type check setup #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded year check (2025) with unconditional warning suppression for PEP 585 deprecation warnings. Changes: - Remove datetime import (no longer needed) - Remove hardcoded _PEP585_DATE constant - Make warning suppression unconditional (still safe with suppress()) - Add AttributeError to exception suppression for robustness - Add clarifying comments about PEP 585 and removal timeline Benefits: - Fix will not break in 2026 when year > 2025 - More future-proof and maintainable - Clearer intent through documentation - No functional change to current behavior PEP 585 (Python 3.9+) allows list[]/dict[] instead of typing.List[]/typing.Dict[]. The suppression can be removed when the codebase fully migrates to PEP 585 style hints.
Owner
Author
|
I see why this could be useful, but I'll cross that bridge early next year |
KyleKing
deleted the
claude/fix-runtime-typecheck-date-0164SPN6fj1DYzbYkt1rMYWt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded year check (2025) with unconditional warning suppression for PEP 585 deprecation warnings.
Changes:
Benefits:
PEP 585 (Python 3.9+) allows list[]/dict[] instead of typing.List[]/typing.Dict[]. The suppression can be removed when the codebase fully migrates to PEP 585 style hints.