fix: named code block escape - #152
Open
claustra01 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the markdown-it-named-code-blocks dependency with a small in-repo compatible renderer override that supports “language:filename” fenced code blocks while safely escaping the filename before rendering HTML.
Changes:
- Added a local
namedCodeBlocksmarkdown-it plugin that wraps fenced code blocks with filename markup and escapes filenames viamd.utils.escapeHtml. - Updated the markdown-it setup to use the new local plugin implementation.
- Removed
markdown-it-named-code-blocksfrompackage.jsonand cleaned uppackage-lock.jsonaccordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/namedcodeblocks.js | Introduces the local replacement plugin; strips filename from token.info, renders filename safely, and wraps the rendered fence output. |
| plugins/markdownit.js | Switches the markdown-it plugin import to the new local implementation and continues registering it via md.use(...). |
| package.json | Removes the markdown-it-named-code-blocks dependency. |
| package-lock.json | Removes markdown-it-named-code-blocks and its transitive dependencies from the lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.