Skip to content

feat: add ?limit= to GET /ingestions (#28) - #54

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/ingestions-limit-1cc6
Aug 17, 2026
Merged

cursor[bot] merged 1 commit into
mainfrom
cursor/ingestions-limit-1cc6

Conversation

@leo-aa88

Copy link
Copy Markdown
Member

Closes #28

GET /v1/ingestions (and the deprecated /ingestions alias) hardcoded .limit(25), so older completed jobs dropped out of the list. This adds an optional ?limit= query param (default 25, range 1–500) and returns 400 for out-of-range values. No UI change.

Open in Web Open in Cursor 

GET /v1/ingestions (and the deprecated alias) hardcoded a 25-row cap,
so older completed jobs became unreachable. Accept ?limit= with default
25 and reject values outside 1–500 with 400.

Closes #28.

Co-authored-by: Leonardo <leo-aa88@users.noreply.github.com>
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review — PR #54 (GET /ingestions ?limit=)

Scope matches issue #28: optional limit on GET /ingestions, default 25, 400 for out-of-range values. No UI change. 830 unit tests passed. PR files are ruff-clean.

Must-fix

(None)

Should-fix

(None)

Nice-to-have

  1. clients/openapi.json is stale vs live app.openapi().
  2. RaglogsClient.list_ingestions() cannot pass limit.
  3. OpenAPI schema has no minimum/maximum (manual 400 check is correct).
  4. Non-integer limit is 422, not 400 (same as the rest of FastAPI).
  5. Test helper uses stmt._limit_clause.value.

Verdict

Ready to merge (0 must-fix, 0 should-fix)

@cursor
cursor Bot merged commit bb9ce59 into main Aug 17, 2026
2 checks passed
@leo-aa88
leo-aa88 deleted the cursor/ingestions-limit-1cc6 branch August 17, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(api): add ?limit= to GET /ingestions

2 participants