Skip to content

feat(cli): scope raglogs ask to latest ingestion (#29) - #55

Merged
cursor[bot] merged 3 commits into
mainfrom
cursor/cli-ask-ingestion-1cc6
Aug 17, 2026
Merged

cursor[bot] merged 3 commits into
mainfrom
cursor/cli-ask-ingestion-1cc6

Conversation

@leo-aa88

Copy link
Copy Markdown
Member

Closes #29

raglogs ask now matches explain / timeline / compare: it defaults to the latest completed ingestion, with --ingestion-job and --all-ingestions to override. Invalid UUID exits 1.

ask is registered as a regular Typer command (like explain) so flags work after the question. Nested Typer groups treated trailing options as subcommands.

Open in Web Open in Cursor 

cursoragent and others added 2 commits August 17, 2026 12:28
Match explain/timeline/compare: default to the latest completed
ingestion, with --ingestion-job and --all-ingestions to override.

Closes #29.

Co-authored-by: Leonardo <leo-aa88@users.noreply.github.com>
Nested Typer groups treat trailing options as subcommands, so
`raglogs ask "…" --ingestion-job` failed. Register ask like explain.

Co-authored-by: Leonardo <leo-aa88@users.noreply.github.com>
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

GitHub Actions wraps Rich help, so `--ingestion-job` can split across
lines or pick up ANSI. Strip color, collapse whitespace, and pin a
wide dumb terminal before asserting the flags.

Co-authored-by: Leonardo <leo-aa88@users.noreply.github.com>
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review — PR #55 (CLI ask ingestion scope)

Closes #29. Ingestion wiring matches explain/timeline. Changing ask from a nested Typer group to a regular command is correct and necessary so trailing flags after the question work. No ask subcommands were lost. 835 unit tests passed.

Must-fix

(None)

Should-fix

(None)

Nice-to-have

  1. Scope banner on stdout with --format json will break jq pipes (explain has the same gap).
  2. Help test could also assert usage is ask [OPTIONS] [question] with no Commands section.

Verdict

Ready to merge (0 must-fix, 0 should-fix)

@cursor
cursor Bot merged commit 6722aac into main Aug 17, 2026
2 checks passed
@leo-aa88
leo-aa88 deleted the cursor/cli-ask-ingestion-1cc6 branch August 17, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cli): scope raglogs ask to a specific ingestion (--ingestion-job-id / --all-ingestions)

2 participants