Skip to content

Display warning if JavaScript is disabled, fixes #15 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlueskyFR wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Display warning if JavaScript is disabled, fixes #15 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,17 @@ <h1 class="flex flex-wrap">
</div>
</header>

<div class="wrapper">
<noscript>
<div id="noscript" class="d-flex align-items-center flex-column justify-content-center">
<p>
Comment on lines +52 to +53

@NerOcrO NerOcrO Apr 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div id="noscript" class="d-flex align-items-center flex-column justify-content-center">
<p>
<p id="noscript" class="d-flex align-items-center flex-column justify-content-center">

@BlueskyFR BlueskyFR Apr 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas rebuild pour vérifier mais tu as bien checké que l'affichage reste toujours le même via ce changement (propriétés par défaut du div et du p qui ne sont pas les mêmes ?) ?

Pour pouvoir utiliser ce générateur, il vous faut préalablement activer JavaScript.<br />
Comment thread
BlueskyFR marked this conversation as resolved.
<a href="https://www.enable-javascript.com/fr/">Cliquez ici</a> pour accéder aux instructions
pour activer JavaScript dans votre navigateur.
Comment thread
BlueskyFR marked this conversation as resolved.
</p>
</div>

@NerOcrO NerOcrO Apr 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>

</noscript>

<div id="wrapper" class="wrapper d-none">
<form id="form-profile">
<h2 class="titre-2">Remplissez en ligne votre attestation numérique :</h2>

Expand Down Expand Up @@ -268,6 +277,11 @@ <h3>Choisissez un motif de sortie</h3>
sein de ce navigateur ! Merci d'ouvrir Chrome sur Android ou bien Safari sur iOS.
</div>

<script>
document.addEventListener("DOMContentLoaded", function() {
document.querySelector("#wrapper").classList.remove("d-none");
});
Comment on lines +281 to +283

@NerOcrO NerOcrO Apr 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cela me semble overkill d'ajouter du JS, j'aurai mis le texte en rouge.

@BlueskyFR BlueskyFR Apr 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca évite toute confusion au moins.

@BlueskyFR BlueskyFR Apr 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu aurais mis quelle partie du texte en rouge ?

</script>
<script src="./certificate.js"></script>
</body>
</html>
11 changes: 11 additions & 0 deletions main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ h2 {
font-size: large;
}

#noscript {
margin: 250px 0 250px 0;

@NerOcrO NerOcrO Apr 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: 250px 0 250px 0;
margin: 250rem 0 250rem 0;

background-color: white;

p {
text-align: center;
font-weight: bold;
font-size: 1.3em;

@NerOcrO NerOcrO Apr 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: 1.3em;
font-size: 1.3rem;

@BlueskyFR BlueskyFR Apr 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quel avantage les rem ont-ils par rapport aux em ?

@williamdes williamdes Apr 13, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://caniuse.com/#feat=mdn-api_css_em

https://caniuse.com/#feat=rem

Le support des rem semble meilleur, non ?

}
}

footer {
margin-top: 40px;
}
Expand Down