Add Dockerfile for Selkies project and update build configuration #10
+141
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for building a new Docker image based on the Selkies project's NVIDIA EGL desktop environment, targeting enhanced GPU acceleration and virtual desktop capabilities. The changes enable multi-image builds from different Dockerfiles within the same workflow.
- Added a new Dockerfile.selkies for building GPU-accelerated desktop containers with ROS2 and L-CAS customizations
- Updated GitHub Actions workflow to support building multiple Docker images using different Dockerfiles
- Integrated Zenoh ROS2 bridge and Node.js for enhanced connectivity and development capabilities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Dockerfile.selkies | New Dockerfile for Selkies-based image with NVIDIA GPU support, ROS2, and L-CAS tools |
| .github/workflows/docker-build.yaml | Updated build matrix to include new Selkies image and support different Dockerfiles per target |
Co-authored-by: Copilot <[email protected]>
…ge-selkies:ubuntunoble
…se configuration for lcas_desktop service
…/webtop:ubuntu-xfce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for building a new Docker image based on the
selkies-project/nvidia-egl-desktop:24.04base, targeting enhanced NVIDIA GPU and ROS2 integration. The main changes include adding a newDockerfile.selkies, updating the GitHub Actions workflow to build and push this new image, and improving flexibility in selecting Dockerfiles for different build targets.Docker build enhancements:
Dockerfile.selkiesto build images from theghcr.io/selkies-project/nvidia-egl-desktop:24.04base, including ROS2, NVIDIA GPU support, Zenoh ROS2 bridge, Node.js, and L-CAS customizations..github/workflows/docker-build.yamlto include the new Selkies-based image in the build matrix and allow specifying different Dockerfiles for each build target.Workflow improvements:
.github/workflows/docker-build.yamlto dynamically select the Dockerfile based on the matrix configuration, enabling multi-image builds from different Dockerfiles.