-
Notifications
You must be signed in to change notification settings - Fork 10
GH-444: [Eval] Remote DB Usage via Docker Compose #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…remote databases, along with a deployment guide and a Supabase restore script.
Summary of ChangesHello @vibhatha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates the evaluation and testing of remote database services within a production-like Docker Compose environment. It introduces a new Docker Compose configuration that connects to external managed databases like Supabase, MongoDB Atlas, and Neo4j Aura, along with comprehensive documentation for setup and troubleshooting. Additionally, a utility script is provided to streamline the restoration of PostgreSQL backups to Supabase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a production-like Docker Compose setup for using remote databases, along with a script to restore a Postgres database to Supabase. The changes are well-structured.
My review includes a critical security fix for the database restore script to prevent password exposure, and a cleanup suggestion for the new Docker Compose file to improve maintainability. Please see the detailed comments for suggestions.
deployment/choreo/development/docker/postgres/restore_from_github_to_supabase.sh
Show resolved
Hide resolved
|
|
||
| ## Prerequisites | ||
|
|
||
| * Docker Desktop (or Docker Engine + Compose plugin) installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker Desktop or Rancher Desktop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I will fix this.
It is Rancher.
zaeema-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me
This PR includes the following
This PR closes #444