-
Notifications
You must be signed in to change notification settings - Fork 3
GH-94 : [UI][STYLES] Update states, redirects and chart visuals #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e, apply minor UI styling refinements.
… vertical chart layouts.
Summary of ChangesHello @sehansi-9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience within the application's data catalog and visualization features. It streamlines navigation, provides clearer feedback during data loading, and makes chart data more digestible through dynamic labeling and number formatting. The changes aim to create a more intuitive and visually appealing interface for exploring datasets. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several valuable UI/UX improvements, particularly enhancing the charting capabilities and data catalog navigation. The code is now cleaner, with simplified state management in the Version component and more robust loading states in the DataPage. The new chart features, such as tiltable labels and number abbreviation, are excellent additions. I've included a few comments with suggestions for refactoring to improve code consistency and maintainability. Overall, this is a solid update.
…plify top value for y axis labels
…ing `URLSearchParams`.
…ata catalog and dataset views
…ic to include error states
ChanukaUOJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
this pr closes #94
This pr fixes redirect issue from org to data tabs, updates the states in data catalog loading, handles chart labels in a more dynamic and user friendly way by introducing tilt-able x-axis labels and dynamic positioning.
Further for better readability chart values are converted to their nearest thousands, millions or billions value with suffixes such as k, m and b