Resolves Iss1568 where LTO build gives warnings about unused variables (

#1590) * Removed numChannelsInSection integer variable. * Added overrides to TrkDeDxMassEstFeatures. * Removed unused variables in TrigScintFirmwareTracker. * Removed Verbosity in TrackDeDxMassEstimator. --------- Co-authored-by: Liam Brennan <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDMX-Software · Feb 11, 2025 · e6acfb2 · e6acfb2
1 parent aa45fd2
commit e6acfb2
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 35 deletions.
diff --git a/DQM/include/DQM/TrkDeDxMassEstFeatures.h b/DQM/include/DQM/TrkDeDxMassEstFeatures.h
@@ -24,12 +24,12 @@ class TrkDeDxMassEstFeatures : public framework::Analyzer {
   /**
    * Input python configuration parameters
    */
-  virtual void configure(framework::config::Parameters& ps);
+  virtual void configure(framework::config::Parameters& ps) override;
 
   /**
    * Fills histograms
    */
-  virtual void analyze(const framework::Event& event);
+  virtual void analyze(const framework::Event& event) override;
 
   /// Method executed before processing of events begins.
   void onProcessStart() override;

diff --git a/Hcal/src/Hcal/HcalDigiProducer.cxx b/Hcal/src/Hcal/HcalDigiProducer.cxx
@@ -320,10 +320,8 @@ void HcalDigiProducer::produce(framework::Event& event) {
     std::vector<ldmx::HcalDigiID> channelMap;
     int numChannels = 0;
     for (int section = 0; section < hcalGeometry.getNumSections(); section++) {
-      int numChannelsInSection = 0;
       for (int layer = 1; layer <= hcalGeometry.getNumLayers(section);
            layer++) {
-        numChannelsInSection += hcalGeometry.getNumStrips(section, layer);
         // Note zero-indexed strip numbering...
         for (int strip = 0; strip < hcalGeometry.getNumStrips(section, layer);
              strip++) {

diff --git a/Recon/include/Recon/TrackDeDxMassEstimator.h b/Recon/include/Recon/TrackDeDxMassEstimator.h
@@ -31,9 +31,6 @@ class TrackDeDxMassEstimator : public framework::Producer {
   virtual void produce(framework::Event& event) override;
 
  private:
-  // specific verbosity of this producer
-  int verbose_{0};
-
   float fit_res_C_{0.};
   float fit_res_K_{-9999.};
 

diff --git a/TrigScint/include/TrigScint/TrigScintFirmwareTracker.h b/TrigScint/include/TrigScint/TrigScintFirmwareTracker.h
@@ -43,9 +43,6 @@ class TrigScintFirmwareTracker : public framework::Producer {
   // min threshold for adding a hit to a cluster
   double minThr_{0.};
 
-  // max number of neighboring hits to combine when forming a cluster
-  int maxWidth_{2};
-
   // specific verbosity of this producer
   int verbose_{0};
 
@@ -68,37 +65,12 @@ class TrigScintFirmwareTracker : public framework::Producer {
   // specific pass name to use for track making
   std::string passName_{""};
 
-  // vertical bar start index
-  int vertBarStartIdx_{52};
-
-  // cluster channel nb centroid (will be content weighted)
-  float centroid_{0.};
-
-  // cluster channel nb horizontal centroid (will be content weighted)
-  float centroidX_{-1};
-
-  // cluster channel nb vertical centroid (will be content weighted)
-  float centroidY_{-1};
-
-  // energy (edep), PE, or sth
-  float val_{0.};
-
-  // edep content, only; leave val_ for PE
-  float valE_{0.};
-
   // book keep which channels have already been added to the cluster at hand
   std::vector<unsigned int> v_addedIndices_;
 
   // book keep which channels have already been added to any cluster
   std::vector<unsigned int> v_usedIndices_;
 
-  // fraction of cluster energy deposition associated with beam electron sim
-  // hits
-  float beamE_{0.};
-
-  // cluster time (energy weighted based on hit time)
-  float time_{0.};
-
   // empty map container
   std::map<int, int> hitChannelMap_;
 };

diff --git a/TrigScint/src/TrigScint/TrigScintFirmwareTracker.cxx b/TrigScint/src/TrigScint/TrigScintFirmwareTracker.cxx
@@ -20,6 +20,7 @@ void TrigScintFirmwareTracker::configure(framework::config::Parameters &ps) {
   verbose_ = ps.getParameter<int>("verbosity");
   timeTolerance_ = ps.getParameter<double>("time_tolerance");
   padTime_ = ps.getParameter<double>("pad_time");
+
   if (verbose_) {
     ldmx_log(info) << "In TrigScintFirmwareTracker: configure done!";
     ldmx_log(info) << "\nClustering threshold: " << minThr_