-
Notifications
You must be signed in to change notification settings - Fork 23
Wketchum/genie generator hep mc3 refactor #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wesketchum
wants to merge
24
commits into
trunk
Choose a base branch
from
wketchum/Genie_Generator_HepMC3Refactor
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/Genie_Generator
…alone SimCore branch
…tract that in the GenieReweightProducer
…m/Genie_Generator_HepMC3Refactor
…m/Genie_Generator_HepMC3Refactor
…efactor' into trunk
…e use of the G4 mass when it is handed off
…m/Genie_Generator_HepMC3Refactor
tomeichlersmith
requested changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a first pass, I just have some big comments
- Please review the coding rules, we solidified the format of variable names and such which you should apply here.
- Is
ldmx::HepMC3GenEvent
necessary? If you just need helper functions, I would prefer you to write those helper function somewhere else rather than derive a new event data type. - Instead of using
if (verbosity ...)
checks, please useldmx_log
. I know we haven't transitioned other parts of SimCore to the logging system, but I would really like to avoid adding new code using the old method. It looks like your verbosity of1
corresponds to thedebug
level. - Does this compile with ldmx/dev:4.2.2? I just want to update the compatibility table if it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This PR enables GENIE simulation that include the following:
Check List
(note, this requires use of the updated docker image described by this PR: LDMX-Software/dev-build-context#105)
An example ldmxsw config is here: https://github.com/wesketchum/LDMX_eN_GENIE/blob/main/ldmxsw_configs/genie_sim.py. From the output of that, one can look at the

genie_truth
tree from the DQM. Attached is a plot of the initial and final lepton energy for a 4 GeV run.Additionally, to see the event reweighting working, here is a screenshot of some screen debug outputs that show weights applied per event.
