Testing for issue #1555 #1557
Closed
Testing for issue #1555 #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-validation |
|
Yaaay it works! 
|
|
One thing tho is that it would have been nice if it shows up under the "Checks" |
|
Ups, it actually overdoes it and every comment now triggers a test (I'll kill the one that's triggered by this) |
|
OK that's also not true, it starts a PR validation workflow but it doesnt run it since it doesnt match the string that's needed to run it, it has the little not-started symbol: 
|
|
/run-validation |
|
The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13076746742. |
I think #1557 (comment) is actually good enough! |
tvami
deleted the
1555-make-pr-validation-ci-triggerable-by-pr-comment-test
branch
tvami
restored the
1555-make-pr-validation-ci-triggerable-by-pr-comment-test
branch
tvami
deleted the
1555-make-pr-validation-ci-triggerable-by-pr-comment-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Testing #1555
Check List