Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverse skimming in vetos #1563

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Inverse skimming in vetos #1563

merged 2 commits into from
Feb 3, 2025

Conversation

tvami
Copy link
Member

@tvami tvami commented Feb 2, 2025 •
edited
Loading

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1561

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

I ran a skim and it contains events that failed the HCAL veto

@tvami tvami marked this pull request as draft February 2, 2025 17:53
@tvami tvami marked this pull request as ready for review February 2, 2025 17:53
@tvami
Copy link
Member Author

tvami commented Feb 3, 2025 •
edited
Loading

Test show no real changes (just whatever we already had in trunk with the versioning), as they should.

@tvami tvami merged commit 9bf6acc into trunk Feb 3, 2025
6 of 13 checks passed
@tvami tvami deleted the iss1561-inverse-skimming branch February 3, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

@danyi211 danyi211 danyi211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to the vetos to flip the skimming logic
3 participants
@tvami @tomeichlersmith @danyi211