Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for iss 1579 #1584

Closed
wants to merge 1 commit into from
Closed

Testing for iss 1579 #1584

wants to merge 1 commit into from

Conversation

tvami
Copy link
Member

@tvami tvami commented Feb 7, 2025

No description provided.

@tvami
Copy link
Member Author

tvami commented Feb 7, 2025

/run-validation

Copy link
Contributor

github-actions bot commented Feb 7, 2025

The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13205437084.

@tvami
Copy link
Member Author

tvami commented Feb 7, 2025

The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13205437084.

So this looks good!

@tvami tvami marked this pull request as draft February 7, 2025 21:50
@tvami tvami marked this pull request as ready for review February 12, 2025 15:49
@tvami
Copy link
Member Author

tvami commented Feb 12, 2025

@tvami
Copy link
Member Author

tvami commented Feb 12, 2025

PR validation in https://github.com/LDMX-Software/ldmx-sw/actions/runs/13289351505/job/37105868680?pr=1584

This looks good now, the label has the PR number
Screenshot 2025-02-12 at 09 42 08

I'm testing for comment-based tests next

@tvami
Copy link
Member Author

tvami commented Feb 12, 2025

/run-validation

Copy link
Contributor

The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13291527969.

@tvami
Copy link
Member Author

tvami commented Feb 12, 2025

OK good with the latest commits, it works for both
Screenshot 2025-02-12 at 11 07 54

@tvami tvami closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant