Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include noise contribution in EcalDigiVerify DQM, fatal error if EcalVeto sees negative energy hits #1585

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Include noise contribution in EcalDigiVerify DQM, fatal error if EcalVeto sees negative energy hits #1585

merged 3 commits into from
Feb 10, 2025

Conversation

tvami
Copy link
Member

@tvami tvami commented Feb 10, 2025

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1502

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@tvami tvami merged commit b9666ad into trunk Feb 10, 2025
11 of 13 checks passed
@tvami tvami deleted the iss1502-ecal-digi-noise branch February 10, 2025 21:50
@tvami tvami mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

@danyi211 danyi211 danyi211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add realistic read-out threshold in ecal digitization
3 participants
@tvami @tomeichlersmith @danyi211