bring back old Hcal digi/reco chain for testing/debug #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a transfer of LDMX-Software/Hcal#75 into this repository.
tvami
reviewed
Feb 11, 2025
| recHit.setSection(hitID.section()); | ||
| recHit.setStrip(hitID.strip()); | ||
| recHit.setLayer(hitID.layer()); | ||
| recHit.setEnergy(edep); |
There was a problem hiding this comment.
Can we add the setOrientation function like I did in https://github.com/LDMX-Software/ldmx-sw/pull/1577/files please?
tvami
reviewed
Feb 11, 2025
| : framework::Producer{name, process} {} | ||
| ~HcalSimpleDigiAndRecProducer() override = default; | ||
| void configure(framework::config::Parameters& ps) override; | ||
| void SetupRandomNumberGeneration(); |
There was a problem hiding this comment.
shouldnt this be lower case, since it's a function, not a class?
tvami
reviewed
Feb 11, 2025
Comment on lines
+7
to
+15
| input_coll_name = ps.getParameter<std::string>("input_coll_name"); | ||
| input_pass_name = ps.getParameter<std::string>("input_pass_name"); | ||
| output_coll_name = ps.getParameter<std::string>("output_coll_name"); | ||
| mev_per_mip = ps.getParameter<double>("mev_per_mip"); | ||
| pe_per_mip = ps.getParameter<double>("pe_per_mip"); | ||
| attenuation_length = ps.getParameter<double>("attenuation_length"); | ||
| readout_threshold = ps.getParameter<int>("readout_threshold"); | ||
| mean_noise = ps.getParameter<double>("mean_noise"); | ||
| position_resolution = ps.getParameter<double>("position_resolution"); |
There was a problem hiding this comment.
also if we follow our (not-yet-written-down) coding rules, these should end with a trailing underscore, showing that these are global variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a transfer of LDMX-Software/Hcal#75 into this repository.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1351
Check List