S30XL testbeam development #1676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvami
requested changes
Apr 3, 2025
| // for (int i = pedLength; i < 3*pedLength ; i++) { | ||
| ////use 2nd and third 5th | ||
| if (charge.size() > 8) { | ||
| if (verbose_) ldmx_log(debug) << "going into oscillations check "; |
There was a problem hiding this comment.
here, I'd recommend to remove the verbose_ and move to ldmx_log(trace)
| ////use 2nd and third 5th | ||
| if (charge.size() > 8) { | ||
| if (verbose_) ldmx_log(debug) << "going into oscillations check "; | ||
| for (int i = 3; i < charge.size() - 4; i++) { |
There was a problem hiding this comment.
Can you add a comment on why we are skipping the first 2? is this supposed to be pedOffset+1? If yes, I'd prefer to move to a named constant than just a the hardcoded number
| if (verbose_) ldmx_log(debug) << "going into oscillations check "; | ||
| for (int i = 3; i < charge.size() - 4; i++) { | ||
| float maxSamp = minCharge; | ||
| for (int iQ = 0; iQ < 4; iQ++) { // find the local max in the 4 samples |
There was a problem hiding this comment.
I guess a same comment about having the 4 a named constant
| // ldmx_log(debug) << "got charge " << charge[i+iQ]; | ||
| if (charge[i + iQ] > maxSamp) maxSamp = charge[i + iQ]; | ||
| } | ||
| if (verbose_) ldmx_log(debug) << "got max charge " << maxSamp; |
There was a problem hiding this comment.
Suggested change
| if (verbose_) ldmx_log(debug) << "got max charge " << maxSamp; | |
| ldmx_log(trace) << "got max charge " << maxSamp; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Some changes to the setup compared to CERN testbeam 2022 (notably: number of time samples, number of bits actually used in TDC format, and the number of channels) meant that some tweaks to a series of producers and analyzers were due.
Check List