Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crc32c dependency with crc-any #4

Closed
wants to merge 1 commit into from
Closed

Replace crc32c dependency with crc-any #4

wants to merge 1 commit into from

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Feb 6, 2024

Fixes #3

@LDeakin
Copy link
Owner Author

LDeakin commented Feb 6, 2024

I should compare performance of crc32c and crc-any at some point.
This is a private dependency, so there is no problem to flip between them.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88c3cc3) 66.29% compared to head (1c47ec2) 66.35%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   66.29%   66.35%   +0.05%     
==========================================
  Files         115      115              
  Lines       16580    16534      -46     
==========================================
- Hits        10992    10971      -21     
+ Misses       5588     5563      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin added the wontfix This will not be worked on label Feb 9, 2024
@LDeakin LDeakin closed this Feb 9, 2024
@LDeakin LDeakin deleted the crc-any branch February 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly build broken due to crc32c using the removed unstable stdsimd feature
2 participants