Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage types #5

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Refactor storage types #5

merged 1 commit into from
Feb 12, 2024

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Feb 12, 2024

This is mostly an internal change, but downstream users may need to:

  • Arc wrap storage transformers
  • In methods generic over storage, add a 'static lifetime to storage

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (ceb1018) 77.58% compared to head (daff3f0) 77.57%.

Files Patch % Lines
...e/storage_transformer/storage_transformer_chain.rs 22.91% 37 Missing ⚠️
src/storage/storage_transformer/usage_log.rs 17.24% 24 Missing ⚠️
...storage/storage_transformer/performance_metrics.rs 24.13% 22 Missing ⚠️
src/array/array_async_readable.rs 0.00% 4 Missing ⚠️
src/array/array_async_writable.rs 0.00% 4 Missing ⚠️
src/array/array_sync_readable.rs 66.66% 1 Missing ⚠️
src/array/array_sync_writable.rs 75.00% 1 Missing ⚠️
src/array/codec.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   77.58%   77.57%   -0.02%     
==========================================
  Files         123      123              
  Lines       17612    17606       -6     
==========================================
- Hits        13665    13658       -7     
- Misses       3947     3948       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit 5eab757 into main Feb 12, 2024
16 of 18 checks passed
@LDeakin LDeakin deleted the storage_refactor branch February 12, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant