Skip to content

the stepsize doesn't change now #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syh6585 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

the stepsize doesn't change now #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions src/main/scala/collaborativeFiltering/MatrixFactorization.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ class MatrixFactorization extends Serializable{
val testTimeStart = System.currentTimeMillis()
val bc_test_itemFactors = ratingsByRow.context.broadcast(itemFactors)
//training loss
val loss = ratingsByRow.mapPartitions {iter =>
val loss = ratingsByRow.mapPartitionsWithIndex {(index,iter) =>
val localV = bc_test_itemFactors.value
val localU = MatrixFactorization.workerstore.get[Map[Int, Vector]]("userFactors")
val localU = MatrixFactorization.workerstore.get[Map[Int, Vector]](s"userFactors_$index")
val reguV = localV.mapValues(v => lambda_v * v.dot(v))
val reguU = localU.mapValues(u => lambda_u * u.dot(u))
val ls = iter.foldLeft(0.0) { (l, r) =>
Expand All @@ -125,7 +125,7 @@ class MatrixFactorization extends Serializable{
l + residual * residual + reguU.get(r.index_x).get + reguV.get(r.index_y).get
}
Iterator.single(ls)
}.reduce(_ + _) / numRatings
}.sum() / numRatings
bc_test_itemFactors.unpersist()
print(s"$loss\t")
testTime += (System.currentTimeMillis() - testTimeStart)
Expand Down Expand Up @@ -160,7 +160,6 @@ class MatrixFactorization extends Serializable{
val vj = localV.get(ranRating.index_y).get
//update vj
val residual = ranRating.rating - uh.dot(vj)
val rrr = stepsize * residual
vj *= (1 - stepsize * lambda_v)
vj.plusax(stepsize * residual, uh)
loss += (residual * residual)
Expand All @@ -178,15 +177,15 @@ class MatrixFactorization extends Serializable{
itemFactors.foreach(ui => ui._2 /= numParts.toDouble)
bc_itemFactors.unpersist()

val approxLoss = lossSum / (numParts * numInnerIters)
if (i != 0) {
val oldLoss = lossList.last
if (approxLoss > oldLoss)
stepsize = stepsize * 0.5
else
stepsize *= 1.05
}
lossList.append(approxLoss)
// val approxLoss = lossSum / (numParts * numInnerIters)
// if (i != 0) {
// val oldLoss = lossList.last
// if (approxLoss > oldLoss)
// stepsize = stepsize * 0.5
// else
// stepsize *= 1.05
// }
// lossList.append(approxLoss)

// println(s"approximate loss: $approxLoss, time: ${System.currentTimeMillis() - startTime}")

Expand Down